Feat Implement fetch-database.ts
#788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for wargabantuwarga ready! 🔨 Explore the source changes: cad0913 🔍 Inspect the deploy log: https://app.netlify.com/sites/wargabantuwarga/deploys/613648ab4a50cf0007889712 😎 Browse the preview: https://deploy-preview-788--wargabantuwarga.netlify.app |
|
Can you help me with this one, Mas @zainfathoni? |
due to the complexity of mocking fetch that hinders us from testing fetch-database.ts
Codecov Report
@@ Coverage Diff @@
## main #788 +/- ##
==========================================
+ Coverage 84.91% 86.30% +1.38%
==========================================
Files 134 134
Lines 1425 1438 +13
Branches 455 458 +3
==========================================
+ Hits 1210 1241 +31
+ Misses 211 193 -18
Partials 4 4
Continue to review full report at Codecov.
|
while asserting the expected result through the mock file
since it's relatively faster than fetchSheets, at least for now
since fetchWbw() is an IIFE (Immediately Invoked Function Expression) which makes it harder to test while returning not so much value to the stability of the code
since fetchWbw() is an IIFE (Immediately Invoked Function Expression) which makes it harder to test while returning not so much value to the stability of the code
zainfathoni
approved these changes
Sep 6, 2021
There was a problem hiding this comment.
LGTM 💯
Thanks for working on the implementation, @hanihusam! 🙏
zainfathoni
added
automerge
This was referenced Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #784
Description
Implement
fetch-database.tsto fetch from https://kcov.id/wbw-database